Fix ignored type variable bound warning in type quote pattern #18199
Conversation
nicolasstucki
force-pushed
the
fix-ignored-type-quote-pattern-type-variable-bound-inference-warning
branch
from
63e03ab to
e9d18bd
Compare
| @@ -3,7 +3,8 @@ | |||
| | ^ | |||
| | Ignored bound <: Double | |||
| | | |||
| | Consider defining bounds explicitly `'{ type t <: Int & Double; ... }` | |||
| | This kind of pattern will be supported with SIP-53. | |||
There was a problem hiding this comment.
Could the message mention the experimental import or link to the doc page on it if we have one?
There was a problem hiding this comment.
I noticed that this message can only be shown in an experimental context. We do not need this extra warning.
The only way to have this way to get code like this is using one of the two addition of SIP-53. Those are caught just before this check in https://github.com/lampepfl/dotty/pull/18199/files#diff-2eae364f82b9f4896588e75bfe0bdda905455d0d76136914f7a8909005048bf2R174-R177
nicolasstucki
force-pushed
the
fix-ignored-type-quote-pattern-type-variable-bound-inference-warning
branch
2 times, most recently
from
c9e89c3 to
b698052
Compare
| .addMode(Mode.Pattern) | ||
| .withOwner(quoteOwner(ctx)) | ||
|
|
||
| /** Owner of the quoted pattern */ |
There was a problem hiding this comment.
Is the documentation accurate since it also does something when we're not in a quoted pattern?
There was a problem hiding this comment.
I updated the documentation and name of the definition
| | Ignored bound <: Double | ||
| | | ||
| | Consider defining bounds explicitly: | ||
| | '{ type t <: Int & Double; ... } |
There was a problem hiding this comment.
I wonder if we could take advantage of #17561 to automatically propose a rewrite that does that.
There was a problem hiding this comment.
I am considering doing that. The complication is finding the position where this needs to be inserted. It would be also be a bit more challenging if we consider handling two of these errors at the same time. I plan to try this in the near future.
| case '{ $_ : F[t, t]; () } => // warn // error | ||
| case '{ type u <: Int & Double; $_ : F[u, u] } => | ||
|
|
||
| type F[x <: Int, y <: Double] |
There was a problem hiding this comment.
Could you add an example involving an F-bounds (like type Foo[T <: Comparable[T]])?
There was a problem hiding this comment.
Added am example in tests/neg-macros/quote-type-variable-no-inference-3.scala
nicolasstucki
force-pushed
the
fix-ignored-type-quote-pattern-type-variable-bound-inference-warning
branch
from
b698052 to
c8a7eee
Compare
nicolasstucki
deleted the
fix-ignored-type-quote-pattern-type-variable-bound-inference-warning
branch
See the diff in tests/neg-macros/quote-type-variable-no-inference.check